CLOUDP-297223: Add support for private and public preview spec generation #432
Conversation
| } | ||
|
|
||
| // WithFullContent returns an Option to generate a new APIVersion given the contentType and contentValue. | ||
| func WithFullContent(contentType string, contentValue *openapi3.MediaType) Option { |
There was a problem hiding this comment.
core change: we need to consider contentValue to gather version data, since for preview and private preview we have the same content type atlas.vnd.preview+json, we can only differentiate them based on the x-xgen-preview extension
| } | ||
|
|
||
| func (v *APIVersion) IsPrivatePreview() bool { | ||
| return strings.Contains(v.version, PrivatePreviewStabilityLevel) |
There was a problem hiding this comment.
Why don't you call IsPreviewSabilityLevel(v.version) here?
There was a problem hiding this comment.
IsPreviewSabilityLevel returns true to either Public or Private previews so we need to check for private preview here, but open to other suggestions
andreaangiolillo
changed the title
| } | ||
| } | ||
|
|
||
| func TestSplitPublicPreviewRun(t *testing.T) { |
There was a problem hiding this comment.
I use the command locally to generate the spec and I noticed that the private preview file has several components that I think are not needed. Is this expected?
test-private-preview-info-resource.json
I am wondering if this is okay and will be fixed once we add the filter to remove the unused view 🤔
There was a problem hiding this comment.
Yes, we should cover removing unused stuff after split together, for now we're validating we're filtering out the paths, which is the most important resource
| } | ||
|
|
||
| // GetPreviewVersionName returns the preview version name. | ||
| func GetPreviewVersionName(contentTypeValue *openapi3.MediaType) (name string, err error) { |
There was a problem hiding this comment.
Does this need to be public? 👀
| func GetPreviewVersionName(contentTypeValue *openapi3.MediaType) (name string, err error) { | |
| func getPreviewVersionName(contentTypeValue *openapi3.MediaType) (name string, err error) { |
There was a problem hiding this comment.
I think yes cause we use it in the versions package
3 participants
Proposed changes
Jira ticket: CLOUDP-297223
Checklist
Changes to Spectral
Further comments